fix: should avoid through variables in inlined module#18845
Merged
alexander-akait merged 1 commit intowebpack:mainfrom Oct 14, 2024
Merged
fix: should avoid through variables in inlined module#18845alexander-akait merged 1 commit intowebpack:mainfrom
alexander-akait merged 1 commit intowebpack:mainfrom
Conversation
Contributor
|
For maintainers only:
|
alexander-akait
approved these changes
Oct 11, 2024
Member
alexander-akait
left a comment
There was a problem hiding this comment.
Looks good, after tests, we can merge
Contributor
Author
|
@alexander-akait I'll add the related test and clean code tonight (in about 10 hours), after that, we're good to merge. |
a8cecd5 to
a41d7d8
Compare
Contributor
|
@fi3ework Thanks for your update. I labeled the Pull Request so reviewers will review it again. @alexander-akait Please review the new changes. |
a41d7d8 to
bb10e4b
Compare
Member
|
@fi3ework Is it ready to merge? |
Contributor
Author
|
@alexander-akait Yes, it's ready for review. |
alexander-akait
approved these changes
Oct 14, 2024
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
What does it fix:
Changes overview:
lib/optimize/ConcatenatedModule.jsinlib/javascript/JavascriptModulesPlugin.jslib/util/concatenate.jsfromlib/optimize/ConcatenatedModule.jsand remove the duplicated inlib/javascript/JavascriptModulesPlugin.jsSynmbolas a js globals toRESERVED_NAMES.Did you add tests for your changes?
Yes.
Does this PR introduce a breaking change?
No, but there's an API
findNewNameis removed fromlib/javascript/JavascriptModulesPlugin.js, do we need to preserve that? I'm not clear about are the methods of plugins are treated as the stable stuff. If so, we could simply proxy the refactored method.What needs to be documented once your changes are merged?
No.