perf(buildChunkGraph): avoid unneeded re-visit#18730
Merged
alexander-akait merged 1 commit intowebpack:mainfrom Sep 3, 2024
Merged
perf(buildChunkGraph): avoid unneeded re-visit#18730alexander-akait merged 1 commit intowebpack:mainfrom
alexander-akait merged 1 commit intowebpack:mainfrom
Conversation
Contributor
|
For maintainers only:
|
6d2eae6 to
612dbde
Compare
612dbde to
2e994c8
Compare
2 tasks
alexander-akait
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Improve performance of code-splitting
see following module-graph
if module
otherhas a lots of sub modules, we can avoid revisit those modules if minAvailableModules stays the sameCurrent behavior
module a dyn imports module b, buildChunkGraph will first create chunk a for module a, fills chunk a, then create chunk b for module b, fills chunk b.
if module b has another parent, then chunk b will be outdated and will be visited again, and fills chunk b again. But if chunk b has no minAvailableModules changes, we can skip visiting it, as it won't have any differences
Did you add tests for your changes?
No
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?