feat: reduce unnecessary exports runtime#18565
Merged
alexander-akait merged 1 commit intowebpack:mainfrom Jul 10, 2024
Merged
Conversation
Contributor
|
For maintainers only:
|
This was referenced Jul 10, 2024
alexander-akait
approved these changes
Jul 10, 2024
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
The initial goal of this PR is to reduce unnecessary runtime code in
modern-module. As__webpack_exports__and related define property runtime is not needed.Contains following changes:
Explicit define
RuntimeGlobals.exportsinstead of using the always pre-rendered__webpack_exports__in source, only render it when runtime requirements exist.RuntimeGlobals.onChunksLoadedis added, also addingRuntimeGlobals.exportsRuntimeGlobals.exportstolib/library/AssignLibraryPlugin.jsandlib/library/ExportPropertyLibraryPlugin.jsto inherit the explicit definedRuntimeGlobals.exportsruntime.Do not render
RuntimeGlobals.exports&RuntimeGlobals.definePropertyGettersin modern-module mode.Did you add tests for your changes?
Yes.
Does this PR introduce a breaking change?
I don't think so.
__webpack_exports__is striped only when is useless.What needs to be documented once your changes are merged?
No.