Skip to content

fix: error with contenthash and css experiment#18512

Merged
alexander-akait merged 2 commits intowebpack:mainfrom
titouanmathis:main
Jun 19, 2024
Merged

fix: error with contenthash and css experiment#18512
alexander-akait merged 2 commits intowebpack:mainfrom
titouanmathis:main

Conversation

@titouanmathis
Copy link
Contributor

@titouanmathis titouanmathis commented Jun 18, 2024

What kind of change does this PR introduce?

This is a bugfix for #18511 (fixes #18511).

Did you add tests for your changes?

Guidance to where tests should be added needed.

Does this PR introduce a breaking change?

No.

What needs to be documented once your changes are merged?

No documentation needed.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 18, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: alexander-akait / name: Alexander Akait (8efac43)
  • ✅ login: titouanmathis / name: Titouan Mathis (23be8db)

@webpack-bot
Copy link
Contributor

Hi @titouanmathis.

Just a little hint from a friendly bot about the best practice when submitting pull requests:

Don't submit pull request from your own main branch. It's recommended to create a feature branch for the PR.

You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR.

@alexander-akait
Copy link
Member

Added a test case

@alexander-akait alexander-akait merged commit 0d07d65 into webpack:main Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error with [contenthash] not being implemented when the CSS experiment is enabled

3 participants