Skip to content

ci: run tests on node v19#16813

Closed
snitin315 wants to merge 2 commits intowebpack:mainfrom
snitin315:ci/add-node-19
Closed

ci: run tests on node v19#16813
snitin315 wants to merge 2 commits intowebpack:mainfrom
snitin315:ci/add-node-19

Conversation

@snitin315
Copy link
Member

@snitin315 snitin315 commented Mar 12, 2023 •
edited by alexander-akait
Loading

What kind of change does this PR introduce?
CI (also need update deps).

Run tests on node 19 as well.

Did you add tests for your changes?
No need.

Does this PR introduce a breaking change?
No

What needs to be documented once your changes are merged?
Nothing

@webpack-bot
Copy link
Contributor

webpack-bot commented Mar 12, 2023

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@snitin315
Copy link
Member Author

snitin315 commented Mar 12, 2023

I believe we need to update jest.

@alexander-akait
Copy link
Member

alexander-akait commented Mar 12, 2023

Wierd:

Unable to find JEST_STATE_SYMBOL in Symbol(jest-native-promise), Symbol(jest-native-now), Symbol(jest-native-read-file), Symbol(jest-native-write-file), Symbol(jest-native-exists-file), Symbol($$jest-matchers-object), Symbol(graceful-fs.queue)

I believe we need to update jest.

Yeah, but we still need to run tests on Node.js v10, anyway we try to update jest and install old version of jest for v10

@snitin315 snitin315 mentioned this pull request Mar 13, 2023
Merged
@TheLarkInn
Copy link
Member

TheLarkInn commented Mar 14, 2023

@snitin315

This is the suspect code:

webpack/test/helpers/createLazyTestEnv.js

Lines 1 to 12 in b7fc4d8

const STATE_SYM = Object.getOwnPropertySymbols(global).find(
Symbol("x").description
? s => s.description === "JEST_STATE_SYMBOL"
: s => s.toString() === "Symbol(JEST_STATE_SYMBOL)"
);
if (!STATE_SYM) {
throw new Error(
`Unable to find JEST_STATE_SYMBOL in ${Object.getOwnPropertySymbols(global)
.map(s => s.toString())
.join(", ")}`
);
}

It appears to break due to any Node version > 16

@alexander-akait
Copy link
Member

alexander-akait commented Mar 15, 2023

I will look at this

@alexander-akait
Copy link
Member

alexander-akait commented Mar 19, 2023

@SimenB Friendly ping, maybe you can give us some advices, I tried to find why it doesn't work on v18 and no luck, I found jest has require("jest-circus/build/state").getState(), but it looks like return no current state, because currentDescribeBlock.tests is empty. So what is the big different between jest v27 on Node v16 and Node v18? May it be a bug?

@alexander-akait alexander-akait mentioned this pull request Apr 9, 2023
Merged
@snitin315 snitin315 deleted the ci/add-node-19 branch April 12, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: unreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@snitin315 @webpack-bot @alexander-akait @TheLarkInn