Conversation
Contributor
|
For maintainers only:
|
sokra
requested changes
Apr 7, 2022
Comment on lines
+58
to
+77
| /** | ||
| * @param {ModuleGraph} moduleGraph the module graph | ||
| * @returns {string[]} the imported ids | ||
| */ | ||
| getIds(moduleGraph) { | ||
| const meta = moduleGraph.getMetaIfExisting(this); | ||
| if (meta === undefined) return this.ids; | ||
| const ids = meta[idsSymbol]; | ||
| return ids !== undefined ? ids : this.ids; | ||
| } | ||
|
|
||
| /** | ||
| * @param {ModuleGraph} moduleGraph the module graph | ||
| * @param {string[]} ids the imported ids | ||
| * @returns {void} | ||
| */ | ||
| setIds(moduleGraph, ids) { | ||
| moduleGraph.getMeta(this)[idsSymbol] = ids; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Actually you don't need that for tree shaking.
these [sg]etIds stuff is only used for https://github.com/webpack/webpack/blob/main/lib/optimize/SideEffectsFlagPlugin.js and that checks only for HarmonyExportImportedSpecifierDependency and HarmonyImportSpecifierDependency.
Contributor
vankop
commented
Apr 11, 2022
| if (this._hashUpdate === undefined) { | ||
| this._hashUpdate = | ||
| this.identifier + (this.path ? this.path.join(",") : "null"); | ||
| this._hashUpdate = this.identifier + (this.ids ? this.ids.join(",") : ""); |
Member
Author
There was a problem hiding this comment.
null property could be in ids
sokra
approved these changes
Jul 25, 2022
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
closes #12441
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing