support context in Dependency#15585
Merged
Merged
Conversation
Contributor
|
For maintainers only:
|
483e053 to
b9cca71
Compare
b9cca71 to
6b1e920
Compare
6b1e920 to
cf5fc90
Compare
vankop
commented
Mar 25, 2022
sokra
requested changes
Mar 25, 2022
sokra
left a comment
Member
There was a problem hiding this comment.
Code looks good. Could you add the bug report as test case too?
Contributor
a9e3aaa to
5605e53
Compare
sokra
approved these changes
Mar 28, 2022
Member
|
Thanks |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactoring/bugfix
fixes #15580
Did you add tests for your changes?
updated existing
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing