Skip to content

add asset modules concatenation#15515

Merged
sokra merged 5 commits intomainfrom
feat/concatenate-assets
Apr 4, 2022
Merged

add asset modules concatenation#15515
sokra merged 5 commits intomainfrom
feat/concatenate-assets

Conversation

@vankop
Copy link
Copy Markdown
Member

@vankop vankop commented Mar 11, 2022

What kind of change does this PR introduce?
feature
closes #13764

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Copy Markdown
Contributor

webpack-bot commented Mar 11, 2022

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@vankop vankop force-pushed the feat/concatenate-assets branch from 96d18b1 to 5f86eb5 Compare March 11, 2022 13:59
sokra
sokra requested changes Mar 15, 2022
View reviewed changes
@webpack-bot
Copy link
Copy Markdown
Contributor

webpack-bot commented Mar 15, 2022

@vankop Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@vankop vankop force-pushed the feat/concatenate-assets branch 2 times, most recently from 1f6d4a1 to 1c0f5c7 Compare March 16, 2022 06:14
@vankop vankop force-pushed the feat/concatenate-assets branch from 1c0f5c7 to 3ec8a60 Compare March 16, 2022 06:23
sokra
sokra requested changes Mar 16, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NormalModule.codeGeneration still runs code generation for all source types, but it only has to run it for source types that remain in the chunk...

I'm also a bit worries about performance drawbacks that comes with these many accesses to sourceTypesByModule, but let's finish that up and measure afterwards...

@vankop vankop force-pushed the feat/concatenate-assets branch from da03829 to 1b7bd14 Compare March 17, 2022 09:05
@vankop
generate only needed source types
3f1715f 
- in ConcatenatedModule generate only js
- in NormalModule generate only used sources
@vankop vankop force-pushed the feat/concatenate-assets branch from 1b7bd14 to 3f1715f Compare March 17, 2022 10:01
vankop
vankop commented Mar 28, 2022
View reviewed changes
@vankop vankop force-pushed the feat/concatenate-assets branch from f23ba1d to 19d1a93 Compare April 4, 2022 10:17
@sokra sokra merged commit c38caa2 into main Apr 4, 2022
@sokra sokra deleted the feat/concatenate-assets branch April 4, 2022 14:04
@sokra
Copy link
Copy Markdown
Member

sokra commented Apr 4, 2022

Thanks

@mattlewis92 mattlewis92 mentioned this pull request Aug 17, 2022
Closed
@JSerFeng JSerFeng mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sokra sokra sokra approved these changes

Assignees

No one assigned

Labels

PR: reviewed-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

asset modules concatenation

3 participants

@vankop @webpack-bot @sokra