fix: a missing semicolon generated by the publicPathRuntime could lead to concatenation issues#15003
fix: a missing semicolon generated by the publicPathRuntime could lead to concatenation issues#15003toovy wants to merge 3 commits intowebpack:mainfrom
Conversation
…d to concatenation issues
|
|
For maintainers only:
|
|
We can fix it, but I recommend report the problem in |
|
|
@toovy Can you accept CLA? |
|
and update the snapshot: |
|
|
|
Sorry, never contributed to a project with a CLA :D so I accepted everything, I think now it should be set up correctly. Updated the snapshops. Anything else? |
|
Hi @toovy. Just a little hint from a friendly bot about the best practice when submitting pull requests:
You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR. |
|
I would merge that PR, but it's conflicting and you didn't gave me permission to edit your branch. So please fix conflict so that can be merged. |
sokra
left a comment
There was a problem hiding this comment.
CI failing, snapshots need to be updated
Motivation
In JS you can opt out on using
;on line endings. Some consider this good style, some bad style. I don't care until it generates issues. When concatenating source code missing;can lead to issues. Consider the generated code:In my case the generated code that does not use a
;led to issues when using it with a non-webpack concatenation (WPRocket):Obviously most of the times you would just minify using webpack with the terser plugin, which works flawlessly, but in our case we will use WPRockets concatenation and minification and want the unminified code.
What kind of change does this PR introduce?
Bugfix
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Nothing