Skip to content

Update example multi-part-library#14896

Closed
Hydrock wants to merge 1 commit intowebpack:mainfrom
Hydrock:main
Closed

Update example multi-part-library#14896
Hydrock wants to merge 1 commit intowebpack:mainfrom
Hydrock:main

Conversation

@Hydrock
Copy link
Copy Markdown

@Hydrock Hydrock commented Dec 3, 2021

Added a quotation mark, just to make it beautiful.

Added a quotation mark, just to make it beautiful
@linux-foundation-easycla
Copy link
Copy Markdown

CLA Not Signed

@webpack-bot
Copy link
Copy Markdown
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Copy Markdown
Contributor

Hi @Hydrock.

Just a little hint from a friendly bot about the best practice when submitting pull requests:

Don't submit pull request from your own main branch. It's recommended to create a feature branch for the PR.

You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR.

@alexander-akait
Copy link
Copy Markdown
Member

Please accept CLA

Copy link
Copy Markdown
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • this also need to be updated in the README.md in the same directory
  • please accept the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants