Skip to content

attach require with property dependencies to the correct DependenciesBlock#14725

Merged
sokra merged 2 commits intomainfrom
bugfix/require-ensure-full-require
Nov 15, 2021
Merged

attach require with property dependencies to the correct DependenciesBlock#14725
sokra merged 2 commits intomainfrom
bugfix/require-ensure-full-require

Conversation

@sokra
Copy link
Copy Markdown
Member

@sokra sokra commented Nov 13, 2021

fixes #14720

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
TODO

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Copy Markdown
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@scameron
Copy link
Copy Markdown
Contributor

I notice there are a bunch of addPresentationalDependecy calls also made on module instead of current. But they are all like that, so I guess that's correct, right? (I'm not sure what a presentation dependency is...)

@webpack-bot
Copy link
Copy Markdown
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra
Copy link
Copy Markdown
Member Author

sokra commented Nov 15, 2021

I notice there are a bunch of addPresentationalDependecy calls also made on module instead of current. But they are all like that, so I guess that's correct, right? (I'm not sure what a presentation dependency is...)

That's fine. presentational dependencies only exist on Module not on AsyncDependenciesBlock. That are dependencies that doesn't point to a module and have only effects on the generated code. They are often not walked, as they do not influence the module graph, etc.

@sokra sokra marked this pull request as ready for review November 15, 2021 08:04
@sokra sokra merged commit cc990fe into main Nov 15, 2021
@sokra sokra deleted the bugfix/require-ensure-full-require branch November 15, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inside require.ensure, using require with chained property causes dependencies to be added to wrong chunk

3 participants