fix: fixed work of the non-system type externals for "system" library target#13754
Merged
sokra merged 1 commit intowebpack:mainfrom Jul 12, 2021
Merged
Conversation
Contributor
|
For maintainers only:
|
Contributor
Author
|
Dear maintainers - it would be great to make & release similar fix for Webpack 4. So if you don't mind, I'll sent PR to v4 branch. This will simplify life for me A LOT. |
Contributor
Author
|
@sokra Hi! I see you're trying to fix the CI being unstable sometimes. I believe here tests got failed not because of the changes but rather CI issues. Could you take a look? |
sokra
approved these changes
Jul 12, 2021
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This tiny change makes externals with custom type specified work correctly with "system" library target.
Now they only work with "umd" library target because of these lines:
webpack/lib/library/UmdLibraryPlugin.js
Lines 126 to 133 in c181294
I see similar issue with AMD bundle type too, but let's start with System.js first ;)
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
I believe not :)
What needs to be documented once your changes are merged?
Nothing :)