Conversation
Contributor
|
For maintainers only:
|
d278524 to
39b8425
Compare
vankop
commented
Jul 26, 2020
| * @returns {boolean} | ||
| */ | ||
| module.exports = function (config) { | ||
| if (config.mode === "production") return false; |
Member
Author
There was a problem hiding this comment.
Terser does not supports optional chaining yet.
terser/terser#567
nullish coalescing works on try.terser.org, but not optimized.
39b8425 to
fb561e9
Compare
0fbb348 to
1eacb07
Compare
vankop
commented
Aug 7, 2020
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Member
|
Thanks |
|
Thanks! Is there an estimation on when this will be released? |
Member
|
@dreyks It's already released https://github.com/webpack/webpack/releases/tag/v5.0.0-beta.25 |
|
will it be ported to the stable branch or will it only be available in webpack 5? |
Member
|
@dreyks only for webpack@5 |
|
btw terser 5.2.0 is out now with the optional chaining support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
closes #11186
closes #10227
cherry-pick from #11198
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing