fix: add missing optional peer dependency webpack-cli#11189
Merged
sokra merged 2 commits intowebpack:masterfrom Jul 20, 2020
Merged
fix: add missing optional peer dependency webpack-cli#11189sokra merged 2 commits intowebpack:masterfrom
sokra merged 2 commits intowebpack:masterfrom
Conversation
|
|
Contributor
|
For maintainers only:
|
Member
|
|
Member
|
Is it allowed to use |
Contributor
Author
|
Yes, Yarn 2 and potentially pnpm will treat it as if you also specified Yarn 1 and probably npm will just ignore it |
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Member
|
@sokra we use same for webpack-dev-server, https://github.com/webpack/webpack-dev-server/blob/master/package.json#L119 /cc @arcanis it is valid, right? |
|
Yep! 👍 |
Member
|
Thanks |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Webpack tries to require
webpack-cliwithout declaring it as a optional peer dependency which causes it to not get access to it under Yarn PnPFixes half of yarnpkg/berry#1452
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
No
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
N/A