feat: update terser to version 4#94
Closed
alan-agius4 wants to merge 1 commit intowebpack:masterfrom
alan-agius4:update-terser
Closed
feat: update terser to version 4#94alan-agius4 wants to merge 1 commit intowebpack:masterfrom alan-agius4:update-terser
alan-agius4 wants to merge 1 commit intowebpack:masterfrom
alan-agius4:update-terser
Conversation
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 5 5
Lines 283 283
Branches 113 113
=======================================
Hits 278 278
Misses 5 5Continue to review full report at Codecov.
|
Member
|
Ci fail |
Author
|
The failure doesn’t seem related https://dev.azure.com/webpack-contrib/terser-webpack-plugin/_build/results?buildId=153 |
Member
|
/cc @fabiosantoscode it is safe to release as minor version, not major (we require node@6)? |
Contributor
|
@evilebottnawi The internal AST has changed. If you allow your users to access the internal AST like this then it's a major change. |
Member
|
Thanks, we don't allow developers use ast so it is minor release, thanks |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Breaking Changes
Additional Info
Full terser changelog https://github.com/terser-js/terser/blob/master/CHANGELOG.md#v400