fix: use webpack.sources when it's available#301
Merged
alexander-akait merged 2 commits intowebpack:masterfrom Aug 20, 2020
Merged
fix: use webpack.sources when it's available#301alexander-akait merged 2 commits intowebpack:masterfrom
alexander-akait merged 2 commits intowebpack:masterfrom
Conversation
Member
|
Tests are broken |
Contributor
Author
Seems like this is caused by a newer version of webpack being used and not really by this PR. |
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
==========================================
+ Coverage 94.53% 94.55% +0.01%
==========================================
Files 5 5
Lines 366 367 +1
Branches 143 144 +1
==========================================
+ Hits 346 347 +1
Misses 19 19
Partials 1 1
Continue to review full report at Codecov.
|
Member
|
Thanks! |
This was referenced Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
https://github.com/webpack/webpack/releases/tag/v5.0.0-beta.27
We ran into this issue with the latest serializer so @sokra exposed the webpack-sources classes on the
sourcesproperty in webpack itselfBreaking Changes
Not breaking
Additional Info