Skip to content

feat: update Terser to version 5#285

Merged
alexander-akait merged 1 commit intowebpack:masterfrom
chicoxyzzy:update_terser
Aug 4, 2020
Merged

feat: update Terser to version 5#285
alexander-akait merged 1 commit intowebpack:masterfrom
chicoxyzzy:update_terser

Conversation

@chicoxyzzy
Copy link
Copy Markdown
Contributor

@chicoxyzzy chicoxyzzy commented Aug 3, 2020 •
edited
Loading

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Terser 5 release =)

Breaking Changes

minify and transform are async now

Additional Info

@jsf-clabot
Copy link
Copy Markdown

jsf-clabot commented Aug 3, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 3, 2020 •
edited
Loading

Codecov Report

Merging #285 into master will decrease coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
- Coverage   94.97%   94.56%   -0.41%     
==========================================
  Files           5        5              
  Lines         398      368      -30     
  Branches      156      142      -14     
==========================================
- Hits          378      348      -30     
  Misses         19       19              
  Partials        1        1
Impacted Files Coverage Δ
src/index.js 96.04% <100.00%> (-0.75%) ⬇️
src/minify.js 88.50% <100.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b4dbc...b8017d7. Read the comment docs.

@chicoxyzzy chicoxyzzy force-pushed the update_terser branch 5 times, most recently from 509217a to 52f8137 Compare August 3, 2020 11:18
chicoxyzzy
chicoxyzzy commented Aug 3, 2020
View reviewed changes
test/__snapshots__/terserOptions-option.test.js.snap.webpack4
"Terser Plugin: Dropping unused function foo [main.js:91,9]",
]
`;
exports[`terserOptions option should match snapshot for the "warnings" option with the "true" value: warnings 1`] = `Array []`;
Copy link
Copy Markdown
Contributor Author

@chicoxyzzy chicoxyzzy Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why these arrays are empty now 🤔

Copy link
Copy Markdown
Contributor Author

@chicoxyzzy chicoxyzzy Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warnings are deprecated terser/terser@71dc345

Copy link
Copy Markdown
Member

@alexander-akait alexander-akait Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is very bad, very

@alexander-akait
Copy link
Copy Markdown
Member

alexander-akait commented Aug 3, 2020

/cc @fabiosantoscode Why warnings was removed? Can you provide more information?

@chicoxyzzy chicoxyzzy force-pushed the update_terser branch 2 times, most recently from 09273ba to f9529da Compare August 3, 2020 14:18
alexander-akait
alexander-akait reviewed Aug 3, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will do new major release in near future

@chicoxyzzy chicoxyzzy force-pushed the update_terser branch 2 times, most recently from e607eed to 42f264e Compare August 3, 2020 15:10
@alexander-akait
Copy link
Copy Markdown
Member

alexander-akait commented Aug 3, 2020

I will do the next major release tomorrow with terser@5, if you do rebase, it helps me, thanks!

@chicoxyzzy
Copy link
Copy Markdown
Contributor Author

chicoxyzzy commented Aug 3, 2020

tests are flaky

@alexander-akait
Copy link
Copy Markdown
Member

alexander-akait commented Aug 4, 2020

github actions bugs on mac os, reported many time, but no luck

@alexander-akait alexander-akait mentioned this pull request Aug 4, 2020
Merged
6 tasks
@chicoxyzzy
Copy link
Copy Markdown
Contributor Author

chicoxyzzy commented Aug 4, 2020

oh, I didn't notice lint error. will fix it now

@alexander-akait
Copy link
Copy Markdown
Member

alexander-akait commented Aug 4, 2020

I already do new PR, no need removing warnings, it is warnings from webpack, anyway big thanks for the PR

@chicoxyzzy
Copy link
Copy Markdown
Contributor Author

chicoxyzzy commented Aug 4, 2020 •
edited
Loading

that's why I created the second commit which could be simply dropped from PR

@alexander-akait
Copy link
Copy Markdown
Member

alexander-akait commented Aug 4, 2020

If you remove it then I can merge your work and make a little more changes

@alexander-akait
Copy link
Copy Markdown
Member

alexander-akait commented Aug 4, 2020

Or we can merge it #291 😄

@TrySound
Copy link
Copy Markdown

TrySound commented Aug 4, 2020

Better merge the one which is first.

@chicoxyzzy
Copy link
Copy Markdown
Contributor Author

chicoxyzzy commented Aug 4, 2020

it's dropped

@alexander-akait alexander-akait merged commit b5e6b8d into webpack:master Aug 4, 2020
@alexander-akait
Copy link
Copy Markdown
Member

alexander-akait commented Aug 4, 2020

Thanks

@chicoxyzzy chicoxyzzy deleted the update_terser branch August 4, 2020 13:06
@chicoxyzzy chicoxyzzy mentioned this pull request Aug 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-akait alexander-akait alexander-akait left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chicoxyzzy @jsf-clabot @alexander-akait @TrySound