fix: logic for extracting and preserving comments#166
Merged
alexander-akait merged 1 commit intomasterfrom Sep 24, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
=======================================
Coverage 99.36% 99.36%
=======================================
Files 5 5
Lines 313 313
Branches 123 125 +2
=======================================
Hits 311 311
Misses 2 2
Continue to review full report at Codecov.
|
a30b7e5 to
5424798
Compare
5424798 to
17bfe10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Fix logic for extracting and preserving comments
Breaking Changes
Potentially yes, but previously behavior was be invalid:
extractCommentwithoutconditionsomeand you can't disable thisSome of bugs are very not convenient and cause problems with setup, also comments is not break code so we mark this as patch release.
Additional Info
No