-
-
Notifications
You must be signed in to change notification settings - Fork 167
Closed
Description
- Operating System: Fedora 32
- Node Version: 12
- NPM Version: 6
- webpack Version: 4
- terser-webpack-plugin Version: 4.2.0
Expected Behavior
extractComments to extract and add a banner always.
Actual Behavior
extractComments doesn't reliably add the banner. Sometimes, maybe 50% of the time, it will remove comments, but won't add the banner. The [contenthash] is the same regardless which causes caching and SRI issues as the hash does not reflect the content without the banner.
Code
I can try to provide code, but I noticed the tests for extractComments is failing so possibly that will help.
https://github.com/webpack-contrib/terser-webpack-plugin/runs/1103414191?check_suite_focus=true
FAIL test/minify-option.test.js
● Console
console.log
Current webpack version: 4
at Object.<anonymous> (test/helpers/snapshotResolver.js:10:9)
● minify option › should snapshot with extracting comments
EINVAL: invalid argument, rmdir '/Users/runner/work/terser-webpack-plugin/terser-webpack-plugin/node_modules/.cache/terser-webpack-plugin/content-v2/sha512/12/ec'
How Do We Reproduce?
See above.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels