fix: support webpack 5 FileSystemInfo API by vankop · Pull Request #190 · webpack/stylelint-webpack-plugin

vankop · 2019-10-20T15:53:27Z

This PR contains a:

Motivation / Use-Case

#187

Breaking Changes

no

Additional Info

no

codecov-io · 2019-10-20T15:55:31Z

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #190   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines         102    112   +10     
  Branches       20     23    +3     
=====================================
+ Hits          102    112   +10

Impacted Files	Coverage Δ
src/LintDirtyModulesPlugin.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 435dd43...af0e7d6. Read the comment docs.

ricardogobbosouza

Hi @vankop
Some considerations
Thanks

ricardogobbosouza · 2019-10-21T12:23:24Z

src/LintDirtyModulesPlugin.js

+  }
+
+  return fileTimestamps;
+}


We have a big loss here mapping all the entries.
No need this function

yep, you are right

ricardogobbosouza · 2019-10-21T12:26:00Z

src/LintDirtyModulesPlugin.js

+    mapFileTimestampsToOldFormat(compilation.fileSystemInfo._fileTimestamps)
+  );
+}
+


No need this function, create a const in apply function

ricardogobbosouza · 2019-10-21T12:26:50Z

src/LintDirtyModulesPlugin.js

@@ -14,16 +33,17 @@ export default class LintDirtyModulesPlugin {
  apply(compilation, callback) {


Create a const here to check if exists fileSystemInfo

const fileTimestamps = compilation.fileTimestamps || compilation.fileSystemInfo.getDeprecatedFileTimestamps()

ricardogobbosouza · 2019-10-21T12:28:41Z

src/LintDirtyModulesPlugin.js

    if (this.isFirstRun) {
      this.isFirstRun = false;
-      this.prevTimestamps = compilation.fileTimestamps;
+      this.prevTimestamps = getFileTimestamps(compilation);


Use new const fileTimestamps

ricardogobbosouza · 2019-10-21T12:28:48Z

src/LintDirtyModulesPlugin.js

    }

    const dirtyOptions = { ...this.options };
+    const newTimestamps = getFileTimestamps(compilation);


ricardogobbosouza · 2019-10-21T12:28:53Z

src/LintDirtyModulesPlugin.js

+    const newTimestamps = getFileTimestamps(compilation);
    const glob = dirtyOptions.files.join('|').replace(/\\/g, '/');
-    const changedFiles = this.getChangedFiles(compilation.fileTimestamps, glob);
+    const changedFiles = this.getChangedFiles(newTimestamps, glob);


Use new const fileTimestamps

ricardogobbosouza · 2019-10-21T12:28:57Z

src/LintDirtyModulesPlugin.js

+    const changedFiles = this.getChangedFiles(newTimestamps, glob);

-    this.prevTimestamps = compilation.fileTimestamps;
+    this.prevTimestamps = newTimestamps;


Use new const fileTimestamps

ricardogobbosouza · 2019-10-21T12:34:37Z

We need to add tests

sokra · 2019-10-21T12:50:30Z

src/LintDirtyModulesPlugin.js

+  return (
+    compilation.fileTimestamps ||
+    // eslint-disable-next-line no-underscore-dangle
+    mapFileTimestampsToOldFormat(compilation.fileSystemInfo._fileTimestamps)


_fileTimestamps is private. Don't do that! That's not how FileSystemInfo works. fileSystemInfo._fileTimestamps is a cache, while in webpack 4 compilation.fileTimestamps was a complete list.

Use the public functions to access timestamps of files.

Just use getDeprecatedFileTimestamps from FileSystemInfo

@sokra could we have a method getFileTimestamps so as not to depend on a getDeprecatedFileTimestamps function that will be depreciated?

getFileTimestamps() { return this._fileTimestamps; }

vankop · 2019-10-21T16:13:39Z

Thanks for all your replies!

_fileTimestamps is private. Don't do that! That's not how FileSystemInfo works. fileSystemInfo._fileTimestamps is a cache

I found out that it is cache (all timestamps that was created via getFileTimestamp method), but did not understand how to take all timestamps in other way (since getDeprecatedFileTimestamps also use cache) or my vision is mistaken and we must use just getDeprecatedFileTimestamps here? Maybe we can use snapshots here somehow? @sokra could you please guide me a little bit here

Just use getDeprecatedFileTimestamps from FileSystemInfo

@ricardogobbosouza Unfortunately getDeprecatedFileTimestamps will not work as expected either. Hope @sokra will clarify usage a little bit.

We need to add tests

So I can upgrade dev dependency to webpack@5 ?

vankop · 2019-10-22T08:00:52Z

Lets wait for webpack/webpack#9679

thasmo · 2019-11-20T19:16:37Z

@vankop, seems like the PR was merged and should be included with the next beta (beta.7) when released.

lf-jeremy · 2019-11-21T13:04:17Z

beta.7 is out and does include the PR

alexander-akait · 2019-11-21T13:45:39Z

/cc @vankop @ricardogobbosouza what is status?

vankop · 2019-11-21T13:48:46Z

@evilebottnawi sorry I did not have time, hope on the nearest weekend I can try to migrate on beta.7 .

ricardogobbosouza · 2019-12-02T20:10:49Z

@vankop @evilebottnawi
I created another PR #199, with a simpler integration.

fix: support webpack 5 FileSystemInfo API

af0e7d6

ricardogobbosouza requested changes Oct 21, 2019

View reviewed changes

sokra reviewed Oct 21, 2019

View reviewed changes

thasmo mentioned this pull request Nov 4, 2019

List of files modified during watch cycle is now accessible to plugins webpack/webpack#9679

Merged

ricardogobbosouza mentioned this pull request Dec 2, 2019

fix: support webpack 5 #199

Merged

6 tasks

ricardogobbosouza closed this in #199 Dec 4, 2019

vankop deleted the lint-dirty-modules-plugin branch December 4, 2019 14:57

		@@ -14,16 +33,17 @@ export default class LintDirtyModulesPlugin {
		apply(compilation, callback) {

Uh oh!

Conversation

vankop commented Oct 20, 2019

Motivation / Use-Case

Breaking Changes

Additional Info

Uh oh!

codecov-io commented Oct 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ricardogobbosouza left a comment

Choose a reason for hiding this comment

Uh oh!

ricardogobbosouza Oct 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ricardogobbosouza Oct 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ricardogobbosouza commented Oct 21, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ricardogobbosouza Oct 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vankop commented Oct 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vankop commented Oct 22, 2019

Uh oh!

thasmo commented Nov 20, 2019

Uh oh!

lf-jeremy commented Nov 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexander-akait commented Nov 21, 2019

Uh oh!

vankop commented Nov 21, 2019

Uh oh!

ricardogobbosouza commented Dec 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov-io commented Oct 20, 2019 •

edited

Loading

ricardogobbosouza Oct 21, 2019 •

edited

Loading

ricardogobbosouza Oct 21, 2019 •

edited

Loading

ricardogobbosouza Oct 21, 2019 •

edited

Loading

vankop commented Oct 21, 2019 •

edited

Loading

lf-jeremy commented Nov 21, 2019 •

edited

Loading

ricardogobbosouza commented Dec 2, 2019 •

edited

Loading