feat!: remove legacy Sass JS API support#1314
Merged
Merged
Conversation
The legacy Sass JS API is deprecated upstream. Drop the `api: "legacy"` option, the legacy code path in the loader, the legacy `getWebpackImporter`, and all related tests, helpers, and documentation. The `api` option now accepts `"modern"` and `"modern-compiler"` only. Snapshots are updated to reflect the removal.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1314 +/- ##
==========================================
- Coverage 94.13% 92.30% -1.83%
==========================================
Files 3 3
Lines 409 299 -110
Branches 154 104 -50
==========================================
- Hits 385 276 -109
+ Misses 22 20 -2
- Partials 2 3 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api: "legacy"option; theapioption now accepts"modern"and"modern-compiler"only.getWebpackImporter, legacy sass options, legacy error /stats.includedFileshandling,render()callback path).getCodeFromSass,getImplementationsAndAPI), drop the now-unusedcustomImporterhelper, simplifycustomFunctions, and drop the "legacy JS API is deprecated" filter fromnormalizeErrors.isModernAPIternaries fromloader.test.js,sassOptions-option.test.js,sourceMap-options.test.js,implementation-option.test.js,webpackImporter-options.test.js, andvalidate-options.test.js.webpackImporter-optionsnow runs against modern APIs.old API/new APIannotations, dropLegacyOptionsfromsassOptionstype, switch examples tostyle: "compressed", update theapioption enum, and add a migration note.Test plan
jest— full test suite passes (validate-options, implementation-option, loader, sassOptions-option, sourceMap-options, additionalData-option, webpackImporter-options, warnRuleAsWarning, cjs, resolver).npm run test:manual(not run here).Breaking change
Users on
api: "legacy"must migrate to the modern Sass JS API. See the Sass JS API docs.https://claude.ai/code/session_01FRaLy2pGK8wueLft9F2tmG
Generated by Claude Code