test: lower the mock.module live-exports cutoff from Node 26 to Node 24

claude · claude · commit 82b4fd1ca6c1 · 2026-05-16T09:48:09.000Z
The previous fix split per Node major: `namedExports` for < 26, getter-backed `exports` for >= 26. Node 24's CI leg then failed because Node 24 *also* snapshots `namedExports` (the option is deprecated there too — only Node 22 still reads it live). A probe on Node 24.15.0: | Option | Behavior on Node 22 | 24 | 26 | | -------------------------- | ------------------- | -- | -- | | `namedExports` (live wrap) | LIVE | snapshot | (deprecated/snapshot) | | `exports` (plain spread) | option ignored | snapshot | snapshot | | `exports` (getter wrap) | option ignored | LIVE | LIVE | So the cutoff is *Node 22 only* for `namedExports`; Node 24+ has to use the getter-backed `exports` form. Lower the version branch to `NODE_MAJOR < 24` accordingly. Verified on Node 22.22.2, 24.15.0, 26.1.0: 1158 pass / 0 fail / 0 skipped each. https://claude.ai/code/session_01XWs5VsKDPMo38kskxHoiRM
diff --git a/test/implementation-option.test.js b/test/implementation-option.test.js
@@ -74,12 +74,11 @@ const sassEmbeddedEsmURL = resolveEsmEntry("sass-embedded");
 // `sassEmbedded` must propagate to the loader's view, which means
 // `mock.module`'s exports have to read from the wrapper *live*.
 //
-// On Node 22 / 24, `mock.module({ namedExports, defaultExport })` is
-// already live — internally those keys are accessed each time the
-// mocked module is loaded. On Node 26, the deprecated keys are gone
-// and the new unified `exports` option snapshots values at synthesis
-// time, so we have to thread reads through getters that delegate to
-// the wrapper.
+// On Node 22, `mock.module({ namedExports, defaultExport })` is live by
+// itself. Starting with Node 24 those options are deprecated and the
+// new unified `exports` option snapshots values at synthesis time —
+// so on Node 24+ we have to thread reads through getters that delegate
+// to the wrapper.
 const NODE_MAJOR = Number.parseInt(process.versions.node.split(".")[0], 10);
 
 /**
@@ -89,7 +88,7 @@ const NODE_MAJOR = Number.parseInt(process.versions.node.split(".")[0], 10);
  * @returns {Record<string, unknown>} options accepted by the running Node's `mock.module`
  */
 function mockModuleOptions(target) {
-  if (NODE_MAJOR < 26) {
+  if (NODE_MAJOR < 24) {
     return { namedExports: target, defaultExport: target };
   }
 
