fix(contentHash): Prevent generation of a contentHash for a chunk when the set of css modules is of size 0#1150
Closed
danhcanva wants to merge 1 commit intowebpack:mainfrom
Closed
fix(contentHash): Prevent generation of a contentHash for a chunk when the set of css modules is of size 0#1150danhcanva wants to merge 1 commit intowebpack:mainfrom
danhcanva wants to merge 1 commit intowebpack:mainfrom
Conversation
… modules is of size 0
|
Member
|
@danhcanva Can you accept CLA? |
Author
|
@alexander-akait waiting on legal I will as soon as I can |
Member
|
@danhcanva feel free to ping me when you will ready for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
min-css-extract-plugingenerates contentHash's corresponding to an empty file for chunks with no css modules.Note:
ef46db3751d8e999is the hash of an empty file in the hash algorithm used in the exampleIt does this because it only checks if the set
modulesexists, but the setmodulesis just filtered for css chunks and so in the case there are no css chunks will return a set of length zero which still evaluates as true. See the code changes for more details, it should make sense, comment if it doesn't.What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
No - happy to add if this change looks good
Does this PR introduce a breaking change?
This should not introduce a breaking change, someone may have done something weird with this output though, or assume that
contentHash['css/mini-extract']is defined.If relevant, what needs to be documented once your changes are merged or what have you already documented?
I don't believe there's any documentation required for this.