fix: avoid OOM in CachedInputFileSystem when duration is Infinity#527
Merged
alexander-akait merged 2 commits intomainfrom Apr 17, 2026
Merged
fix: avoid OOM in CachedInputFileSystem when duration is Infinity#527alexander-akait merged 2 commits intomainfrom
alexander-akait merged 2 commits intomainfrom
Conversation
When `duration` is `Infinity`, the constructor's level-allocation loop (`for (let i = 5000; i < duration; i += 500)`) never terminates, which crashes the process with an out-of-memory error before any file is even resolved. Additionally, scheduling a decay `setTimeout` with an infinite timeout would be meaningless (and clamped by Node). Guard both the level allocation and the async decay timer so that passing `Infinity` yields a never-expiring cache, as users would expect. Closes #368
🦋 Changeset detectedLatest commit: c3c953c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
==========================================
- Coverage 96.75% 96.72% -0.04%
==========================================
Files 50 50
Lines 2589 2593 +4
Branches 788 790 +2
==========================================
+ Hits 2505 2508 +3
- Misses 69 70 +1
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
durationisInfinity, the constructor's level-allocation loop(
for (let i = 5000; i < duration; i += 500)) never terminates, whichcrashes the process with an out-of-memory error before any file is even
resolved. Additionally, scheduling a decay
setTimeoutwith an infinitetimeout would be meaningless (and clamped by Node).
Guard both the level allocation and the async decay timer so that passing
Infinityyields a never-expiring cache, as users would expect.Closes #368