Skip to content

feature: enforceExtension when extensions contain empty string#285

Merged
sokra merged 2 commits intowebpack:masterfrom
iguessitsokay:enforceextensions-empty-string
Apr 19, 2021
Merged

feature: enforceExtension when extensions contain empty string#285
sokra merged 2 commits intowebpack:masterfrom
iguessitsokay:enforceextensions-empty-string

Conversation

@iguessitsokay
Copy link
Copy Markdown
Contributor

enforceExtension should default to true when extensions contain empty string

requested by @sokra to complement webpack pull request:
feat: accept empty string in config.resolve.extensions
webpack/webpack#12613

  • tests added
  • no conflict with existing tests
  • no conflict with webpack

enforceExtension should default to true when extensions contain empty string

requested by @sokra to complement webpack pull request:
feat: accept empty string in config.resolve.extensions
webpack/webpack#12613

- tests added
- no conflict with existing tests
- no conflict with webpack
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 10, 2021

Codecov Report

Merging #285 (c84de67) into master (ff16fc2) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files          39       39           
  Lines        1579     1581    +2     
=======================================
+ Hits         1499     1501    +2     
  Misses         80       80           
Impacted Files Coverage Δ
lib/ResolverFactory.js 97.12% <ø> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff16fc2...c84de67. Read the comment docs.

@sokra
Copy link
Copy Markdown
Member

sokra commented Apr 19, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants