docs: context is localIdentContext in README #1202
Merged
alexander-akait merged 1 commit intowebpack:masterfrom Oct 7, 2020
billbalm:patch-1
Merged
docs: context is localIdentContext in README #1202alexander-akait merged 1 commit intowebpack:masterfrom billbalm:patch-1
alexander-akait merged 1 commit intowebpack:masterfrom
billbalm:patch-1
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #1202 +/- ##
=========================================
Coverage ? 99.40%
=========================================
Files ? 11
Lines ? 676
Branches ? 217
=========================================
Hits ? 672
Misses ? 4
Partials ? 0 Continue to review full report at Codecov.
|
alexander-akait
previously approved these changes
Oct 6, 2020
Member
|
@billbalm Can you fix conflicts? |
Contributor
Author
Done. Please review again. |
alexander-akait
approved these changes
Oct 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Just updating README example code to avoid people get ValidationError from copying those examples over.