feat: add module.type option, the icss option is deprecated#1150
Merged
alexander-akait merged 4 commits intomasterfrom Jul 31, 2020
Merged
feat: add module.type option, the icss option is deprecated#1150alexander-akait merged 4 commits intomasterfrom
module.type option, the icss option is deprecated#1150alexander-akait merged 4 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1150 +/- ##
=======================================
Coverage 99.34% 99.35%
=======================================
Files 10 10
Lines 614 618 +4
Branches 190 193 +3
=======================================
+ Hits 610 614 +4
Misses 4 4
Continue to review full report at Codecov.
|
6 tasks
Contributor
|
awesome, as always thanks for all the hard work 👍 |
|
@evilebottnawi using |
Member
Author
|
@soulofmischief open an new issue with reproducible test repo |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
fixes #1134
Breaking Changes
No
Additional Info
The
icssoption is deprecated