fix: do not execute on a child compilation#507
Merged
alexander-akait merged 2 commits intomasterfrom Jun 18, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
=======================================
Coverage 97.52% 97.52%
=======================================
Files 8 8
Lines 202 202
Branches 55 55
=======================================
Hits 197 197
Misses 5 5
Continue to review full report at Codecov.
|
Contributor
|
@evilebottnawi, is there any chance of getting a release containing this fix cut soon? This is effecting us (the Angular team) in a bad way see angular/angular-cli#18087 |
Member
Author
|
@alan-agius4 Yep, let's do it, want to solve #504 also in this patch, but it is not critical |
Member
Author
Contributor
|
Thanks @evilebottnawi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
fixes #505
Breaking Changes
No
Additional Info
No