feat: remove cjs wrapper and generate types in commonjs format#277
Merged
alexander-akait merged 1 commit intomasterfrom Dec 16, 2021
Merged
feat: remove cjs wrapper and generate types in commonjs format#277alexander-akait merged 1 commit intomasterfrom
alexander-akait merged 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
+ Coverage 95.45% 95.65% +0.19%
==========================================
Files 2 1 -1
Lines 110 115 +5
Branches 43 43
==========================================
+ Hits 105 110 +5
Misses 5 5
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
fixes #273, improve DX for types
Breaking Changes
Potentially yes, but we use babel and our code in commonjs format, so we should generate types in the same format
Additional Info
Now you can use: