Better handling of Redis OOM conditions#970
Merged
rgalanakis merged 6 commits intomainfrom Jun 24, 2025
Merged
Conversation
Set `ASYNC_BACKOFF_DISABLED=true`
Let us know about latency, and if we're in an autoscaling event.
Get the new Amigo 1.10, which will auto-disable backoff job behavior if we are above 90% memory usage.
Allow us to do Webhookdb::Async::Autoscaler.build_autoscaler.unpersist to reset an autoscaling situation, if ever needed.
Handle OOM (command errors) in addition to connection errors.
When we have to use the resilient inserts, make sure we know about it in Sentry.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
==========================================
- Coverage 97.61% 97.61% -0.01%
==========================================
Files 490 490
Lines 31133 31186 +53
==========================================
+ Hits 30392 30443 +51
- Misses 741 743 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a short outage due to Redis OOM issues. This solves for that to prevent a future outage.
Report resilient action fallbacks to Sentry
When we have to use the resilient inserts, make sure we know
about it in Sentry.
Resilient Sidekiq: Also handle OOMs
Handle OOM (command errors) in addition to connection errors.
Autoscaler: Refactor to get an instance
Allow us to do
to reset an autoscaling situation, if ever needed.
Get new Amigo with auto-disabled backoff in OOM
Get the new Amigo 1.10, which will auto-disable backoff job
behavior if we are above 90% memory usage.
Add /system/service_health endpoint
Let us know about latency, and if we're in an autoscaling event.
Allow disabling of queue and semaphore backoff
Set
ASYNC_BACKOFF_DISABLED=true