Signalwire/front: Fix duplicate outbound messages#969
Merged
rgalanakis merged 1 commit intomainfrom Jun 20, 2025
Merged
Conversation
The flow of data for outbound messages goes Front -> this replicator -> Signalwire SMS, then the Signalwire replicator finds that (newly sent) data, and tells us about the new row. However, we already know about this row; we do not want to re-import with sync_outbound! So check if we already have a row using this signalwire id, and noop if so.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #969 +/- ##
=======================================
Coverage 97.61% 97.62%
=======================================
Files 490 490
Lines 31118 31133 +15
=======================================
+ Hits 30376 30393 +17
+ Misses 742 740 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flow of data for outbound messages goes
Front -> this replicator -> Signalwire SMS,
then the Signalwire replicator finds that (newly sent) data, and tells us about the new row.
However, we already know about this row; we do not want to re-import with sync_outbound!
So check if we already have a row using this signalwire id, and noop if so.