Optimize replication migration max(pk)#967
Merged
rgalanakis merged 1 commit intomainfrom Jun 17, 2025
Merged
Conversation
If we have many rows, using `max(pk)` is slow since it uses an index-only scan. Instead, take advantage of the fact that we're grabbing the maximum value of a sequence, and look at its last_value.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #967 +/- ##
=======================================
Coverage 97.61% 97.62%
=======================================
Files 490 490
Lines 31094 31098 +4
=======================================
+ Hits 30353 30358 +5
+ Misses 741 740 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we have many rows, using
max(pk)is slow since it uses an index-only scan.Instead, take advantage of the fact that we're grabbing the maximum value of a sequence,
and look at its last_value.