Resilient fix; improve indices on table/opaqueid rename; use partition key more#966
Merged
rgalanakis merged 4 commits intomainfrom Jun 17, 2025
Merged
Resilient fix; improve indices on table/opaqueid rename; use partition key more#966rgalanakis merged 4 commits intomainfrom
rgalanakis merged 4 commits intomainfrom
Conversation
Not sure what's up with this yet.
Changing a replicator opaque id would result in new indices being built. This does an opaque-id insensitive match on index names when figuring out what indices need to be built during replication migration and calculating 'create index' calls during schema modifications.
When a service integration opaque id changes, it is nice to be able to align index names to reflect the new opaque id. This is not necessary, as the routines now ignore differences in opaque ids when searching for existing indices, but it is nice to not have old names standing around.
Some icalendar actions, like deleting obsolete recurring events for a calendar, were not using the partition key. Make them use it, and make it easier for other partitioned replicators to use the partition key.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #966 +/- ##
==========================================
+ Coverage 97.07% 97.61% +0.53%
==========================================
Files 488 490 +2
Lines 31046 31094 +48
==========================================
+ Hits 30139 30353 +214
+ Misses 907 741 -166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use partition key for bulk operations
Some icalendar actions, like deleting obsolete recurring events
for a calendar, were not using the partition key.
Make them use it, and make it easier for other partitioned
replicators to use the partition key.
Add helper to align index names
When a service integration opaque id changes,
it is nice to be able to align index names to reflect
the new opaque id.
This is not necessary, as the routines now ignore differences
in opaque ids when searching for existing indices,
but it is nice to not have old names standing around.
Do not recreate indices when an opaque id changes
Changing a replicator opaque id would result in
new indices being built. This does an opaque-id
insensitive match on index names when figuring out
what indices need to be built during replication
migration and calculating 'create index' calls
during schema modifications.
Fix Resilient private method access
Not sure what's up with this yet. It caused one-time errors, but wasn't seen since. However, the non-
self.privatemethod access should be used regardless