Advisory locks handle bigint second keys#960
Merged
rgalanakis merged 1 commit intomainfrom Jun 2, 2025
Merged
Conversation
Fixes https://lithic-technology.sentry.io/issues/6651707636 If using `with_advisory_lock(row_pk_that_is_bigint)`, we'd get an error. It should be pretty safe to use an int instead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #960 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 483 483
Lines 30663 30722 +59
=======================================
+ Hits 29732 29791 +59
Misses 931 931 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://lithic-technology.sentry.io/issues/6651707636
If using
with_advisory_lock(row_pk_that_is_bigint), we'd get an error.It should be pretty safe to use an int instead.