Skip to content

Prevent undefined binds when chaining element command overwrites#14985

Merged
christian-bromann merged 3 commits intowebdriverio:mainfrom
anish353:SDK-4116
Jan 8, 2026
Merged

Prevent undefined binds when chaining element command overwrites#14985
christian-bromann merged 3 commits intowebdriverio:mainfrom
anish353:SDK-4116

Conversation

@anish353
Copy link
Contributor

@anish353 anish353 commented Jan 5, 2026

Proposed changes

//: # Ensures command overwrites work for element-only commands by falling back to the origFunction provided by overwriteCommand when no browser-level implementation exists, preventing the previous undefined.bind/prevImpl is not a function crashes during a11y custom scanning.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@anish353 anish353 requested a review from a team as a code owner January 5, 2026 13:36
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 5, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: anish353 / name: Anish Kumar Sinha (780cdda)

@anish353
Copy link
Contributor Author

anish353 commented Jan 6, 2026

@christian-bromann can you please review this PR.

@christian-bromann christian-bromann merged commit aa7f9ca into webdriverio:main Jan 8, 2026
3 checks passed
@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants