Skip to content

chore: UTs genering errors on main#14956

Merged
wswebcreation merged 2 commits intowebdriverio:mainfrom
dprevost-LMI:fix-uts-on-main
Dec 26, 2025
Merged

chore: UTs genering errors on main#14956
wswebcreation merged 2 commits intowebdriverio:mainfrom
dprevost-LMI:fix-uts-on-main

Conversation

@dprevost-LMI
Copy link
Contributor

@dprevost-LMI dprevost-LMI commented Dec 24, 2025 •
edited
Loading

Proposed changes

Some new unit tests, even though passing, are generating subsequent errors both locally and in the pipeline.

Seeing errors in both locally and the pipeline:
image
image

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported

Further comments

Tentative fix suggested by the AI; a second pair of eyes would be helpful! Just closed again if I'm off track again 😉

Reviewers: @webdriverio/project-committers

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 24, 2025 •
edited
Loading

Open in StackBlitz

create-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/create-wdio@14956

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14956

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14956

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14956

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14956

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14956

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14956

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14956

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14956

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14956

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14956

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14956

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14956

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14956

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14956

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14956

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14956

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14956

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14956

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14956

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14956

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14956

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14956

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14956

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14956

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14956

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14956

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14956

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14956

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14956

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14956

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14956

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14956

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14956

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14956

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14956

@wdio/xvfb

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/xvfb@14956

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14956

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14956

commit: b5afc19

@dprevost-LMI dprevost-LMI mentioned this pull request Dec 24, 2025
Closed
@dprevost-LMI dprevost-LMI changed the title fix: failing UTs on main fix: UTs genering errors on main Dec 24, 2025
@dprevost-LMI dprevost-LMI marked this pull request as ready for review December 24, 2025 03:27
@dprevost-LMI
fix: failing UTs on main
b5afc19 
Tentative fix suggested by AI
wswebcreation
wswebcreation approved these changes Dec 25, 2025
View reviewed changes
Copy link
Member

@wswebcreation wswebcreation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wswebcreation
Copy link
Member

wswebcreation commented Dec 25, 2025

By the way @dprevost-LMI , can you use the template when you create a PR, that way we always have the same structure and then it's clear what we fix/when we generate release notes

@dprevost-LMI
Copy link
Contributor Author

dprevost-LMI commented Dec 25, 2025 •
edited
Loading

Sure, let me do that, I usually do, but since this one was only UT, I went too fast!

Done!

@dprevost-LMI dprevost-LMI changed the title fix: UTs genering errors on main chore: UTs genering errors on main Dec 25, 2025
@wswebcreation wswebcreation added the PR: Internal 🏠 PRs that contain changes internals label Dec 26, 2025
@wswebcreation wswebcreation merged commit bcb28fb into webdriverio:main Dec 26, 2025
9 checks passed
@wdio-bot
Copy link
Contributor

wdio-bot commented Dec 26, 2025

Hey dprevost-LMI 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wswebcreation wswebcreation wswebcreation approved these changes

Assignees

No one assigned

Labels

Expensable $25 💸 PR: Internal 🏠 PRs that contain changes internals

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dprevost-LMI @wswebcreation @wdio-bot