fix(webdriverio): fix wildcard support in browser.mock#14944
fix(webdriverio): fix wildcard support in browser.mock#14944christian-bromann merged 1 commit intowebdriverio:mainfrom
Conversation
|
There are many test cases added to the mocking.e2e.ts file , I generated them for testing across multiple scenarios . Let me know if we need to reduce anything |
create-wdio
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/appium-service
@wdio/browser-runner
@wdio/browserstack-service
@wdio/cli
@wdio/concise-reporter
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
@wdio/xvfb
webdriver
webdriverio
commit: |
christian-bromann
left a comment
There was a problem hiding this comment.
This is fantastic, thanks!
|
Hey mccmrunal 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
Proposed changes
FIXES #14811
This PR fixes a critical issue where using wildcard patterns (*,**) in `browser.mock()` would fail with a "Forbidden characters" error when running with WebDriver Bidi.
This is extension to the PR #14817
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
This implementation ensures that
browser.mockworks intuitively with all standardURLPatternwildcard syntaxes while remaining compatible with the strict constraints of the WebDriver Bidi protocol.//: # (If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...)
Reviewers: @webdriverio/project-committers