Skip to content

fixes double config file loading issue and tsx file timing load issue#14904

Merged
christian-bromann merged 3 commits intowebdriverio:mainfrom
mccmrunal:issues/14890
Dec 24, 2025
Merged

fixes double config file loading issue and tsx file timing load issue#14904
christian-bromann merged 3 commits intowebdriverio:mainfrom
mccmrunal:issues/14890

Conversation

@mccmrunal
Copy link
Contributor

@mccmrunal mccmrunal commented Dec 1, 2025 •
edited
Loading

Proposed changes

This PR fixes an issue where the WebdriverIO configuration file was being loaded twice during the wdio run command execution, causing side effects (like logs) to appear twice.

The double loading occurred because:

  1. tsConfigPathFromConfigFile loaded the config with a cache-busting query string (via cacheBustFilePath)
  2. Launcher loaded the config with a clean file path

Node.js treated these as two separate modules.

Additionally, this PR fixes a potential race condition where TypeScript configuration files could fail to load if tsx wasn't registered in time. We now ensure tsx is loaded before attempting to read tsConfigPath from a TypeScript config file.
//: # (Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.)

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

The fix involves:

  1. Removing cacheBustFilePath usage in tsConfigPathFromConfigFile to align with Launcher's loading mechanism.
  2. Adding a check to load tsx early if the config file has a TypeScript extension, ensuring the import succeeds.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 1, 2025 •
edited
Loading

Open in StackBlitz

create-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/create-wdio@14904

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14904

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14904

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14904

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14904

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14904

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14904

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14904

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14904

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14904

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14904

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14904

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14904

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14904

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14904

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14904

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14904

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14904

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14904

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14904

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14904

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14904

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14904

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14904

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14904

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14904

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14904

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14904

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14904

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14904

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14904

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14904

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14904

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14904

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14904

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14904

@wdio/xvfb

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/xvfb@14904

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14904

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14904

commit: c6298e4

@mccmrunal mccmrunal closed this Dec 1, 2025
@mccmrunal mccmrunal reopened this Dec 1, 2025
christian-bromann
christian-bromann approved these changes Dec 24, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit 9f4324c into webdriverio:main Dec 24, 2025
91 of 95 checks passed
@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Dec 24, 2025
@wdio-bot
Copy link
Contributor

wdio-bot commented Dec 24, 2025

Hey mccmrunal 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $35 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mccmrunal @wdio-bot @christian-bromann