fix(webdriverio): get absolute paths using native path.resolve#14793
Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom Nov 29, 2025
Merged
Conversation
|
|
macarie
commented
Sep 29, 2025
d3b5508 to
d4ae8cf
Compare
macarie
commented
Sep 29, 2025
christian-bromann
requested changes
Sep 30, 2025
Member
christian-bromann
left a comment
There was a problem hiding this comment.
I don't think there is a point in having a getAbsoluteFilepath function. We should just remove its usage and replace it with path.resolve.
d4ae8cf to
0af55f4
Compare
Contributor
Author
|
@christian-bromann, removed and used Other than the test in |
This was referenced Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #14780.
Use native
path.resolveto get the absolute path for the given argument as it handles all the edge-cases the previous implementation did not, while maintaining the same behavior:Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers