[v8] Implement BrowserStack CLI support in browserstack service#14617
[v8] Implement BrowserStack CLI support in browserstack service#14617christian-bromann merged 171 commits intowebdriverio:v8from
Conversation
…nd testhub module with dummy hook
|
@christian-bromann, as you suggested, we will move proto files to a separate npm package, and publish compiled js files to import in browserstack service. This includes all .proto files at |
Sounds good! |
Add ignore hooks support for v8
Wdio v8 cli
|
Hi @christian-bromann |
.gitignore
Outdated
| packages/wdio-browserstack-service/src/proto/*.ts | ||
|
|
There was a problem hiding this comment.
| packages/wdio-browserstack-service/src/proto/*.ts |
| "src/@types/**/*" | ||
| ], | ||
| "exclude": [ | ||
| "src/proto/**/*" |
There was a problem hiding this comment.
This should be reverted too?
packages/wdio-types/src/Options.ts
Outdated
| * }) | ||
| * ``` | ||
| */ | ||
| commonCapabilities?: WebdriverIO.Capabilities |
There was a problem hiding this comment.
I don't think we should add an option for BS specific things
|
Hi @christian-bromann, |
|
Hi @christian-bromann, |
|
Hi @christian-bromann, |
|
Hi @christian-bromann, |
Proposed changes
This implements changes in the BrowserStack service to enable BrowserStack products via BrowserStack CLI in the background.
As per the discussion here, this is to work in the direction of moving BrowserStack product-related logic out of webdriverio.
To summarise changes, this implementation consists of
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers