Skip to content

fix(webdriverio): consolidate session manager#13906

Merged
christian-bromann merged 7 commits intomainfrom
cb/session-manager
Jan 9, 2025
Merged

fix(webdriverio): consolidate session manager#13906
christian-bromann merged 7 commits intomainfrom
cb/session-manager

Conversation

@christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Nov 21, 2024 •
edited
Loading

Proposed changes

Currently restarting the session will not reactivate the session manager in the same way, causing e.g. context to be off when someone calls reloadSession. This patch consolidates the session manager and make it easy to register their behavior when a new session is started.

fixes #14046

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 21, 2024 •
edited
Loading

Open in Stackblitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@13906

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@13906

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@13906

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@13906

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@13906

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@13906

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@13906

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@13906

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@13906

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@13906

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@13906

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@13906

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@13906

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@13906

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@13906

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@13906

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@13906

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@13906

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@13906

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@13906

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@13906

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@13906

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@13906

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@13906

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@13906

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@13906

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@13906

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@13906

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@13906

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@13906

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@13906

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@13906

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@13906

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@13906

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@13906

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@13906

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@13906

commit: 34fc03d

This was referenced Nov 21, 2024
Closed
Merged
@christian-bromann christian-bromann marked this pull request as ready for review January 9, 2025 18:23
@nair-sumesh
Copy link
Contributor

nair-sumesh commented Jan 9, 2025

❤️

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 9, 2025
@christian-bromann christian-bromann merged commit b2d2147 into main Jan 9, 2025
45 checks passed
@christian-bromann christian-bromann deleted the cb/session-manager branch January 9, 2025 19:41
@joao-motork
Copy link

joao-motork commented Jan 14, 2025

Hi @christian-bromann

I updated wdio to the latest version (9.5.7) but I am still getting the error related to the reloadSession issue:

Error: WebDriver Bidi command "browsingContext.handleUserPrompt" failed with error: no such frame - Context 20A94A07BD8F2CC9891297F0F8AE44D0 not found

I have attached my project's debug logs. I am running these tests with 4 instances in parallel.

logs.zip

@christian-bromann
Copy link
Member Author

christian-bromann commented Jan 14, 2025

@joao-motork can you provide a minimal reproduction case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: WebDriver Bidi command "browsingContext.navigate" failed with error: no such frame after using reloadSession

3 participants

@christian-bromann @nair-sumesh @joao-motork