Skip to content

Fix moduleLoaderFlag#13768

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
jenskuhrjorgensen:main
Oct 16, 2024
Merged

Fix moduleLoaderFlag#13768
christian-bromann merged 1 commit intowebdriverio:mainfrom
jenskuhrjorgensen:main

Conversation

@jenskuhrjorgensen
Copy link
Contributor

Fix moduleLoaderFlag being set to deprecated --loader instead of --import for Node >= 21 where minor version is < 6.

Proposed changes

See discussion on what this PR fixes here:
#13664

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers:

@christian-bromann

Fix moduleLoaderFlag for Node >= 21 where minor version is < 6
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 16, 2024

CLA Signed

  • ✅login: jenskuhrjorgensen / (c89251f)

The committers listed above are authorized under a signed CLA.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Oct 16, 2024
@christian-bromann christian-bromann merged commit ee692d1 into webdriverio:main Oct 16, 2024
@wdio-bot
Copy link
Contributor

Hey jenskuhrjorgensen 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expensable $25 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants