Skip to content

fix(@wdio/runner): retry on Outdated Optimize Dep Vite errors (#13330)#13331

Merged
christian-bromann merged 2 commits intov8from
cb/retry-outdated-dep-error
Aug 6, 2024
Merged

fix(@wdio/runner): retry on Outdated Optimize Dep Vite errors (#13330)#13331
christian-bromann merged 2 commits intov8from
cb/retry-outdated-dep-error

Conversation

@christian-bromann
Copy link
Member

Proposed changes

Sometimes Vite throws this Outdated Optimize Dep error which we should fix by better bundling WebdriverIO. Until we do that, this patch will help resolve these flakiness by just reloading the page which should give Vite the chance to properly optimize the deps. Furthermore this check helps to make sure we fail the process early in cases a network error happens when the testpage is loaded.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Aug 6, 2024
* fix(@wdio/runner): retry on Outdated Optimize Dep Vite errors

* minor code improvements
@christian-bromann christian-bromann force-pushed the cb/retry-outdated-dep-error branch from 80a60b8 to 51d79e2 Compare August 6, 2024 17:55
@christian-bromann christian-bromann merged commit c6c753f into v8 Aug 6, 2024
@christian-bromann christian-bromann deleted the cb/retry-outdated-dep-error branch August 6, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant