Skip to content

fix(@wdio/utils): Don't download chromedriver with CHROMEDRIVER_PATH #13207

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
johnp:dont-download-chromedriver-if-CHROMEDRIVER_PATH-and-chrome
Jul 22, 2024
Merged

fix(@wdio/utils): Don't download chromedriver with CHROMEDRIVER_PATH #13207
christian-bromann merged 1 commit intowebdriverio:mainfrom
johnp:dont-download-chromedriver-if-CHROMEDRIVER_PATH-and-chrome

Conversation

@johnp
Copy link
Copy Markdown
Contributor

@johnp johnp commented Jul 22, 2024

Proposed changes

Fixes #12933. Note that the bug here was simply downloading Chromedriver needlessly. We did already end up using the chromedriver from CHROMEDRIVER_PATH (verified via strace -f -e trace=process wdio run wdio.conf.js).

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

Given that this might cause needless downloads in CIs around the world, I think we should backport this.

Reviewers: @webdriverio/project-committers

… set

and the browser is in fact chrome/chromium.
Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jul 22, 2024
@christian-bromann christian-bromann merged commit c8b3fb3 into webdriverio:main Jul 22, 2024
@wdio-bot
Copy link
Copy Markdown
Contributor

Hey johnp 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expensable $35 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Chromedriver binary override no longer works

3 participants