feat: display command name for webdriver calls in allure reporter#12982
feat: display command name for webdriver calls in allure reporter#12982christian-bromann merged 4 commits intowebdriverio:mainfrom
Conversation
440e79d to
93d14b3
Compare
|
@sudharsan-selvaraj thanks for taking a step at this. Mind adding a unit test so we can be sure we don't regress? |
Sure @christian-bromann. Will raise a patch with the unit tests. |
|
@christian-bromann I have added the required unit test. Kindly look into it and let me know your thoughts. Thank you! |
|
@sudharsan-selvaraj let's look at things straight, who need |
|
@BorisOsipov sounds good. The step name is now defaulted just to display the command name and added the endpoints as a fallback incase of missing command name. |
christian-bromann
left a comment
There was a problem hiding this comment.
Thank you @sudharsan-selvaraj , changes look good to me 👍
Mind raising a PR for the v8 branch?
@BorisOsipov can you approve?
|
@christian-bromann sure will create a new PR for v8 branch. |
Proposed changes
Currently the allure reporter will display only the endpoint and method name for all webdriver api calls. As part of the change, i have enabled the command name to be also displayed along with the endpoint.
Fixes #12926
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers