@wdio/globals: Declare "expect" global type explicitly#12499
@wdio/globals: Declare "expect" global type explicitly#12499christian-bromann merged 1 commit intowebdriverio:mainfrom
Conversation
christian-bromann
left a comment
There was a problem hiding this comment.
LGTM 👍
Can we make the same change in v8 branch to publish it as latest?
Additional verificationSince |
|
@christian-bromann thanks! I created backport PR #12502 |
|
Hey naruaway 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
Proposed changes
Currently expect-webdriverio is implicitly loading
expectglobal type, which is "wrong" since the runtime of expect-webdriverio does not actually loadexpectinto the runtime global scope.webdriverio/expect-webdriverio#1496 fixes this issue but then we need to make sure to load this type in
@wdio/globals.Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-portedReviewers: @webdriverio/project-committers