Skip to content

[backport] (wdio-config): check existence of ts-node/esm/transpile-only.mjs & fix a type issue#12437

Merged
christian-bromann merged 4 commits intowebdriverio:v8from
johnp:ts-node-compat-v8
Mar 9, 2024
Merged

[backport] (wdio-config): check existence of ts-node/esm/transpile-only.mjs & fix a type issue#12437
christian-bromann merged 4 commits intowebdriverio:v8from
johnp:ts-node-compat-v8

Conversation

@johnp
Copy link
Contributor

@johnp johnp commented Mar 6, 2024 •
edited
Loading

Proposed changes

v8 backport of #12436.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

@johnp johnp mentioned this pull request Mar 6, 2024
Merged
12 tasks
@johnp johnp marked this pull request as ready for review March 6, 2024 01:12
@johnp johnp marked this pull request as draft March 6, 2024 01:15
@johnp johnp force-pushed the ts-node-compat-v8 branch 2 times, most recently from bc84242 to f16c4e3 Compare March 7, 2024 23:36
@johnp johnp force-pushed the ts-node-compat-v8 branch from f16c4e3 to 795bae0 Compare March 7, 2024 23:44
@johnp johnp marked this pull request as ready for review March 7, 2024 23:46
christian-bromann
christian-bromann approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Mar 9, 2024
@christian-bromann christian-bromann merged commit cada81f into webdriverio:v8 Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnp @christian-bromann