Skip to content

Wdio Percy Support v7#11904

Merged
christian-bromann merged 45 commits intowebdriverio:v7from
amaanbs:wdio_percy_support_v7
Feb 7, 2024
Merged

Wdio Percy Support v7#11904
christian-bromann merged 45 commits intowebdriverio:v7from
amaanbs:wdio_percy_support_v7

Conversation

@amaanbs
Copy link
Contributor

@amaanbs amaanbs commented Dec 19, 2023

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@amaanbs amaanbs mentioned this pull request Dec 19, 2023
Merged
8 tasks
@christian-bromann
Copy link
Member

christian-bromann commented Jan 12, 2024 •
edited
Loading

@amaanbs can we incorporate the feedback from #11865 into this PR?

@rev-doshi
Copy link
Contributor

rev-doshi commented Jan 23, 2024

@christian-bromann incorporated the feedback from #11865 in this PR, can you please review?

@christian-bromann
Copy link
Member

christian-bromann commented Feb 4, 2024

@rev-doshi seems like the coverage treshold is not met, can you either add more unit tests or reduce coverage. As we are not actively working on v7 anymore we don't mind reducing the coverage treshold when they block new features to be released.

@christian-bromann
Copy link
Member

christian-bromann commented Feb 7, 2024

@rev-doshi mind updating the snapshots for the junit tests? Just run npx jest packages/wdio-junit-reporter -u

@rev-doshi
Copy link
Contributor

rev-doshi commented Feb 7, 2024

@christian-bromann I ran the command npx jest packages/wdio-junit-reporter -u on my local, but it didn't not change anything that I could commit

christian-bromann
christian-bromann approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will go ahead then and merge. Will try to release v7 today.

Thanks a lot 👍

@christian-bromann christian-bromann added the PR: New Feature 🚀 PRs that contain new features label Feb 7, 2024
@christian-bromann christian-bromann merged commit eeab258 into webdriverio:v7 Feb 7, 2024
@karanshah-browserstack
Copy link

karanshah-browserstack commented Feb 13, 2024

@christian-bromann Did you get a chance to release this? Let us know if there are any blockers.

@christian-bromann
Copy link
Member

christian-bromann commented Feb 13, 2024

This was released as v7.35.0

This was referenced Jul 29, 2024
Merged
Closed
Merged
@hashim21223445 hashim21223445 mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: New Feature 🚀 PRs that contain new features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amaanbs @christian-bromann @rev-doshi @karanshah-browserstack