Skip to content

(internal): change host from 0.0.0.0 to localhost#11542

Closed
erwinheitzman wants to merge 33 commits intowebdriverio:mainfrom
erwinheitzman:run-locally
Closed

(internal): change host from 0.0.0.0 to localhost#11542
erwinheitzman wants to merge 33 commits intowebdriverio:mainfrom
erwinheitzman:run-locally

Conversation

@erwinheitzman
Copy link
Member

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@erwinheitzman
Copy link
Member Author

@christian-bromann I cannot say for sure but it seems like the devtools service is the only thing blocking this from passing. Making these changes locally seems like it does not produce issues when running the same setup (devtools) like we use in the tests, therefore I think it might be the tests and not the code but I'm not confident about this at all and appreciate any help.

@christian-bromann
Copy link
Member

it seems like the devtools service is the only thing blocking this from passing.

I am seeing some unit tests failing as well. I am assuming of these pass the e2e test will fail as of my understanding these settings are needed. I could be wrong though.

@erwinheitzman
Copy link
Member Author

Yeah the unit tests that are failing are related to the devtools/puppeteer as well

@christian-bromann
Copy link
Member

I don't think these tests are related to Puppeteer implementation:

⎯⎯⎯⎯⎯⎯⎯ Failed Tests 2 ⎯⎯⎯⎯⎯⎯⎯

 FAIL  packages/wdio-utils/tests/node/index.test.ts > startWebDriver > should start firefox driver
AssertionError: expected "spy" to be called with arguments: [ { port: 1234, foo: 'bar', …(1) } ]

Received: 

  1st spy call:

  Array [
    Object {
-     "cacheDir": Any<String>,
+     "allowHosts": Array [
+       "localhost",
+     ],
+     "cacheDir": "/tmp",
      "foo": "bar",
      "port": 1234,
    },
  ]


Number of calls: 1

 ❯ packages/wdio-utils/tests/node/index.test.ts:156:34
    154|         })
    155|         expect(startGeckodriver).toBeCalledTimes(1)
    156|         expect(startGeckodriver).toBeCalledWith({
       |                                  ^
    157|             port: 1234,
    158|             foo: 'bar',

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/2]⎯

 FAIL  packages/wdio-utils/tests/node/index.test.ts > startWebDriver > should start no driver or download geckodriver if binaries are defined
AssertionError: expected "spy" to be called with arguments: [ { cacheDir: Any{ …(3) }, …(2) } ]

Received: 

  1st spy call:

  Array [
    Object {
-     "cacheDir": Any<String>,
+     "allowHosts": Array [
+       "localhost",
+     ],
+     "cacheDir": "/tmp",
      "customGeckoDriverPath": "/my/geckodriver",
      "port": 1234,
    },
  ]

@erwinheitzman
Copy link
Member Author

Oh those did not fail for me locally, I can check those when I have time to look into this again

@christian-bromann christian-bromann force-pushed the main branch 2 times, most recently from 19697d0 to c9a3908 Compare December 6, 2023 20:16
@christian-bromann
Copy link
Member

@erwinheitzman it seems like component tests are passing so the driver actually can open on localhost. The issue in build seems to be connected with Puppeteer not able to connect 🤔

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Jan 12, 2024
@christian-bromann christian-bromann marked this pull request as ready for review January 12, 2024 17:34
@christian-bromann
Copy link
Member

I had to do some changes, will merge changes in #12000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants