Skip to content

[v7] Support: Setting session status and name when using BrowserStack Automate TurboScale#11527

Merged
christian-bromann merged 4 commits intowebdriverio:v7from
nagpalkaran95:v7_ats
Oct 25, 2023
Merged

[v7] Support: Setting session status and name when using BrowserStack Automate TurboScale#11527
christian-bromann merged 4 commits intowebdriverio:v7from
nagpalkaran95:v7_ats

Conversation

@nagpalkaran95
Copy link
Contributor

@nagpalkaran95 nagpalkaran95 commented Oct 25, 2023

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

christian-bromann
christian-bromann approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nagpalkaran95 nagpalkaran95 mentioned this pull request Oct 25, 2023
Merged
8 tasks
@christian-bromann
Copy link
Member

christian-bromann commented Oct 25, 2023

@nagpalkaran95 can you check why the windows and mac tests are failing?

@nagpalkaran95
Copy link
Contributor Author

nagpalkaran95 commented Oct 25, 2023 •
edited
Loading

@christian-bromann there is one test failure on windows packages/wdio-utils/tests/test-framework/testFnWrapper-sync.test.js which is unrelated to the changes. Possible to check?

@christian-bromann christian-bromann added the PR: New Feature 🚀 PRs that contain new features label Oct 25, 2023
@christian-bromann christian-bromann merged commit d0e863c into webdriverio:v7 Oct 25, 2023
@christian-bromann
Copy link
Member

christian-bromann commented Oct 25, 2023

LGTM 👍

@nagpalkaran95 nagpalkaran95 deleted the v7_ats branch October 26, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: New Feature 🚀 PRs that contain new features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nagpalkaran95 @christian-bromann